fix(aa): refactor Automated Analysis Recording Setting #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
tthvo
reviewed
May 4, 2023
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/test/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.test.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
There was a problem hiding this comment.
UI looks good!
Not sure if its just me. The editing panel seems crashing in Automated Analysis Drawer -> click on the edit icon just closes the drawer panel.
I think it is the issue with TargetSelect trying to set global selection. This causes the AutomatedAnalysisCard to generateReport -> loading state -> closes the drawer.
See #1014 (comment)
tthvo
reviewed
May 4, 2023
tthvo
reviewed
May 4, 2023
|
Test image available: |
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
tthvo
reviewed
May 4, 2023
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
|
Test image available: |
|
@andrewazores any other comments? |
andrewazores
reviewed
May 5, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
May 5, 2023
src/app/Dashboard/AutomatedAnalysis/AutomatedAnalysisConfigForm.tsx
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
May 5, 2023
andrewazores
approved these changes
May 5, 2023
tthvo
approved these changes
May 5, 2023
|
Test image available: |
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2023
* show current config Signed-off-by: Max Cao <macao@redhat.com> * prevent setting empty template Signed-off-by: Max Cao <macao@redhat.com> * add reset Signed-off-by: Max Cao <macao@redhat.com> * fix some handling Signed-off-by: Max Cao <macao@redhat.com> * redesign Signed-off-by: Max Cao <macao@redhat.com> * redesign 2 Signed-off-by: Max Cao <macao@redhat.com> * update tests and add confirmation Signed-off-by: Max Cao <macao@redhat.com> * re: fixes Signed-off-by: Max Cao <macao@redhat.com> * fix tests Signed-off-by: Max Cao <macao@redhat.com> * localize Signed-off-by: Max Cao <macao@redhat.com> --------- Signed-off-by: Max Cao <macao@redhat.com> (cherry picked from commit 093e003)
ebaron
pushed a commit
that referenced
this pull request
May 5, 2023
* show current config Signed-off-by: Max Cao <macao@redhat.com> * prevent setting empty template Signed-off-by: Max Cao <macao@redhat.com> * add reset Signed-off-by: Max Cao <macao@redhat.com> * fix some handling Signed-off-by: Max Cao <macao@redhat.com> * redesign Signed-off-by: Max Cao <macao@redhat.com> * redesign 2 Signed-off-by: Max Cao <macao@redhat.com> * update tests and add confirmation Signed-off-by: Max Cao <macao@redhat.com> * re: fixes Signed-off-by: Max Cao <macao@redhat.com> * fix tests Signed-off-by: Max Cao <macao@redhat.com> * localize Signed-off-by: Max Cao <macao@redhat.com> --------- Signed-off-by: Max Cao <macao@redhat.com> (cherry picked from commit 093e003) Co-authored-by: Max Cao <macao@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1006
Description of the change:
This puts the current configuration as a expandable panel in the AA recording config settings and allows the user to explicitly edit the configuration. It also prevents null templates from being set as a default configuration.
Motivation for the change:
See #1006